Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate libfreetype install on JDK21 #812

Merged
merged 2 commits into from Feb 1, 2024

Conversation

sxa
Copy link
Member

@sxa sxa commented Jan 29, 2024

Fixes adoptium/temurin-build#3624 (comment) (hopefully!)

Note that I haven't adjusted redhat/src/main/packaging/microsoft/21/msopenjdk-21.spec which still has the rm

I have not tested this, so if a review can fdire off a test and see if the package contains libfreetype.so after this then that would be appreciated.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Jan 29, 2024
@karianna
Copy link
Contributor

CC @joe-braley @d3r3kk to see if we need to do the same for MSFT installers.

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrew-m-leonard
Copy link
Contributor

Unable to test due to: adoptium/infrastructure#3362

@andrew-m-leonard
Copy link
Contributor

@karianna
Copy link
Contributor

Could not compile settings file '/home/jenkins/workspace/adoptium-packages-linux-pipeline_new/linuxRedHat/settings.gradle'.

startup failed:
General error during conversion: Unsupported class file major version 65

Looks like a 'Code was compiled with Java version X vs being run as Java version Y problem

@sxa
Copy link
Member Author

sxa commented Jan 31, 2024

Could not compile settings file '/home/jenkins/workspace/adoptium-packages-linux-pipeline_new/linuxRedHat/settings.gradle'.

startup failed:
General error during conversion: Unsupported class file major version 65

Looks like a 'Code was compiled with Java version X vs being run as Java version Y problem

That is correct, although I'm surprised it hit it in this run because I mitigated that yesterday by changing the default java to be 8 on the machine (See adoptium/infrastructure#3352 (comment) - my understanding from a Slack conversion this week is that the version of gradle we've got needed 8 or something similar). That should not block merging of this PR as it's sure to be a machine specific issue.

https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1202/ is a re-run of Andrew's earlier job on aarch64 instead of x86-64 so will be a better test. I'll try and look at why that (new) machine is misbehaving tomorrow.

@sxa
Copy link
Member Author

sxa commented Feb 1, 2024

https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1202/ is a re-run of Andrew's earlier job on aarch64 instead of x86-64 so will be a better test. I'll try and look at why that (new) machine is misbehaving tomorrow.

That didn't work. Apparently the packaging job is forcing itself to run on an x64 docker host

Still waiting to schedule task
All nodes of label ‘[dockerBuild&&linux&&x64](https://ci.adoptium.net/label/dockerBuild&&linux&&x64/)’ are offline
Running on [dockerhost-equinix-ubuntu2004-x64-1](https://ci.adoptium.net/computer/dockerhost%2Dequinix%2Dubuntu2004%2Dx64%2D1/) in /home/jenkins/workspace/adoptium-packages-linux-pipeline_new

so even using the parameter to build for aarch64 it was still being scheduled on the new machine. I've re-enabled an equinix machine temporarily so we can test this on a known-working configuration - it's at https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1203/console

@sxa
Copy link
Member Author

sxa commented Feb 1, 2024

so even using the parameter to build for aarch64 it was still being scheduled on the new machine. I've re-enabled an equinix machine temporarily so we can test this on a known-working configuration - it's at https://ci.adoptium.net/job/adoptium-packages-linux-pipeline_new/1203/console

That ran green. It's past midnight for me so I've locked the job so the output won't get deleted and we can do some verification / comparison with the GA builds tomorrow (If anyone wants to do so before I go for it then, of course, feel free :-) )

@sxa
Copy link
Member Author

sxa commented Feb 1, 2024

Confirmed that the aarch64 deb and rpm archives from job 1203 linked above are identical other than the presence of the libfreetype.so file, so this change seems good.

Copy link
Contributor

@andrew-m-leonard andrew-m-leonard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@sxa
Copy link
Member Author

sxa commented Feb 1, 2024

Merging, noting that the Alpine apk has the libfreetype.so included so is unaffected and doesn't need a modification.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Temurin 21 JDK does not link to major version of libfreetype or is not statically linked
5 participants