Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

winPB: upgrade wix toolset to v5.0.0 #3545

Merged
merged 2 commits into from May 9, 2024
Merged

winPB: upgrade wix toolset to v5.0.0 #3545

merged 2 commits into from May 9, 2024

Conversation

gdams
Copy link
Member

@gdams gdams commented May 2, 2024 •
edited

Noting that we'll need to manually cleanup the old wix v3.14 installation on all machines

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

@gdams gdams mentioned this pull request May 2, 2024
Merged
karianna
karianna approved these changes May 2, 2024
View reviewed changes
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, but I guess we need to merge this only once we've accepted the Wix 5 installer PR

steelhead31
steelhead31 approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gdams gdams merged commit ff43196 into adoptium:master May 9, 2024
9 checks passed
@gdams gdams deleted the wix branch May 9, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@steelhead31 steelhead31 steelhead31 approved these changes

Assignees
No one assigned
Labels
ansible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gdams @karianna @steelhead31