Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GHA: Migrate semgrep action to centralised workflow #3543

Merged
merged 10 commits into from May 2, 2024

Conversation

steelhead31
Copy link
Contributor

@steelhead31 steelhead31 commented May 2, 2024

Ref: #3371

Migrate the infrastructure semgrep diff github action to use a centralised workflow to reduce maintenance, and reusability.

Checklist

@steelhead31 steelhead31 requested a review from gdams May 2, 2024 10:50
Copy link
Member

@gdams gdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, seeing errors:

[Invalid workflow file: .github/workflows/semgrep_diff.yml#L8](https://github.com/adoptium/infrastructure/actions/runs/8922376330/workflow)
error parsing called workflow
".github/workflows/semgrep_diff.yml"
-> "adoptium/.github/.github/workflows/semgrep_diff.yml@main" (source branch with sha:f02a5f88fca8fc16da8947fce96a8b9a2f528830)
: workflow is not reusable as it is missing a `on.workflow_call` trigger

@steelhead31
Copy link
Contributor Author

I'll take a look..

@steelhead31 steelhead31 requested a review from gdams May 2, 2024 12:38
@steelhead31 steelhead31 marked this pull request as ready for review May 2, 2024 12:44
@karianna karianna merged commit 33714db into adoptium:master May 2, 2024
5 checks passed
@steelhead31 steelhead31 deleted the move_semgrep branch May 3, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants