Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker: Assign port number to static docker container during automated deployment #3511

Merged
merged 4 commits into from Apr 11, 2024
Merged

docker: Assign port number to static docker container during automated deployment #3511

merged 4 commits into from Apr 11, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Apr 8, 2024 •
edited

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

fixes #3505

steelhead31
steelhead31 approved these changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Haroon-Khel
Copy link
Contributor Author

Tested this on dockerhost-azure-ubuntu2204-x64-1, works as expected

sxa
sxa approved these changes Apr 8, 2024
View reviewed changes
Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll approve but food for thought - would this work with podman?

@Haroon-Khel Haroon-Khel merged commit 58d8783 into adoptium:master Apr 11, 2024
10 of 12 checks passed
@Haroon-Khel
Copy link
Contributor Author

would this work with podman?

I am not sure. I didnt think any of our machines were using podman?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karianna karianna karianna approved these changes

@sxa sxa sxa approved these changes

@steelhead31 steelhead31 steelhead31 approved these changes

Assignees
No one assigned
Labels
ansible docker
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Specify port number when deploying Static Docker container
4 participants
@Haroon-Khel @karianna @sxa @steelhead31