Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: script to retrieve static docker containers from jenkins #3423

Merged
merged 5 commits into from Apr 29, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Feb 28, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

ref #3415

Example output

[
    {
        "name": "dockerhost-equinix-ubuntu2004-armv8-1",
        "ip": "147.75.35.203",
        "containers": [
            {
                "nodeName": "test-docker-alpine319-armv8-2",
                "port": "32775"
            },
            {
                "nodeName": "test-docker-alpine319-armv8-4",
                "port": "32777"
            },
            {
                "nodeName": "test-docker-fedora39-armv8l-1",
                "port": "2234"
            },
            {
                "nodeName": "test-docker-sles15-armv8l-1",
                "port": "2236"
            },
            {
                "nodeName": "test-docker-ubuntu1804-armv8l-4",
                "port": "32774"
            },
            {
                "nodeName": "test-docker-ubuntu2004-armv7l-1",
                "port": "2322"
            },
            {
                "nodeName": "test-docker-ubuntu2004-armv7l-2",
                "port": "2323"
            },
            {
                "nodeName": "test-docker-ubuntu2004-armv7l-3",
                "port": "2332"
            },
            {
                "nodeName": "test-docker-ubuntu2004-armv8l-1",
                "port": "32770"
            },
            {
                "nodeName": "test-docker-ubuntu2004-armv8l-2",
                "port": "32771"
            },
            {
                "nodeName": "test-docker-ubuntu2004-armv8l-3",
                "port": "32772"
            },
            {
                "nodeName": "test-docker-ubuntu2204-armv8l-2",
                "port": "32773"
            },
            {
                "nodeName": "test-docker-ubuntu2310-armv8l-1",
                "port": "32776"
            }
        ],
        "containersCount": 13
    }
]

The credentials needed to query jenkins are going to be passed into the script via the Vendor_Files role, which means the credentials need to be stored in the secrets repo

Copy link
Member

@sxa sxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comment on the code yet but noting the typo in the filename which will need to be fixed :-)

@Haroon-Khel Haroon-Khel marked this pull request as ready for review April 24, 2024 15:06
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A block has been put on this Pull Request as this repository is temporarily under a code freeze due to an ongoing release cycle.

If this pull request needs to be merged during the release cycle then please comment /merge and a PMC member will be able to remove the block.

If the code freeze is over you can remove this block by commenting /thaw.

@Haroon-Khel
Copy link
Contributor Author

At the moment it dumps the inventory results into DockerInventory.json which should stay in the same directory as inventory.yml.

I would like a system in place to keep this inventory updated. Could do an automated github action which runs the script, if it detects differences between the output and the existing DockerInventory.json file, it makes a pr to update it. Either way this is beyond this pr

Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@Haroon-Khel
Copy link
Contributor Author

/thaw

@github-actions github-actions bot dismissed their stale review April 29, 2024 08:32

Pull Request unblocked - code freeze is over.

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit dfd14fe into adoptium:master Apr 29, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants