Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Use JDK17 for SLES dockerfiles #3404

Merged
merged 1 commit into from Feb 21, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Feb 20, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Use JDK17 for the java agent. Use the x64 binary in the dockerfile. The dockernode playbook will change the architecture if needed

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one note is that the SLES12 dockerfile (Line 3)  has a reference to the SLES 15.4 repository ( I know this is because a support agreement is required to access the SLES12 repositories ).. it should be noted though, that a system built in this fashion will not be a standard SLES12 system, as various packages get much later updates than those available in SLES12 proper.

RUN zypper ar https://download.opensuse.org/distribution/leap/15.4/repo/oss/ sles15oss

@karianna karianna merged commit e8147c5 into adoptium:master Feb 21, 2024
11 of 16 checks passed
@Haroon-Khel Haroon-Khel deleted the sles.jdk17 branch February 21, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants