Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: fix yaml linter #3401

Closed
wants to merge 5 commits into from
Closed

github: fix yaml linter #3401

wants to merge 5 commits into from

Conversation

sxa
Copy link
Member

@sxa sxa commented Feb 19, 2024

Checklist
  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

Lots of fixes that are now being flagged in my one-line PR change to an unrelated file at #3398 (comment)

Noting that all these changes break the use of git blame or the equivalent in the UI so you will no longer be able to easily tell who made a change but c'est la vie ... Or as @karianna would say "That's why we can't have nice things" ;-)

Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa sxa self-assigned this Feb 19, 2024
@sxa sxa added this to the 2024-02 (February) milestone Feb 19, 2024
@github-actions github-actions bot added the ghActions GitHub Actions label Feb 19, 2024
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa
Copy link
Member Author

sxa commented Feb 19, 2024

Linter checks do not appear to be configured to run on changes to .github/workflow but are covering them, so I've added that into the checks too.

Signed-off-by: Stewart X Addison <sxa@redhat.com>
Signed-off-by: Stewart X Addison <sxa@redhat.com>
@sxa
Copy link
Member Author

sxa commented Feb 19, 2024

I'm going to cancel this on the basis that the checks that were failing in the other PR stopped failing when I re-ran it. Not clear why but I don't really want to spend any more time on this.

@sxa sxa closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

1 participant