Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: Remove out of support fedora and alpine dockerfiles #3399

Merged
merged 3 commits into from Feb 19, 2024

Conversation

Haroon-Khel
Copy link
Contributor

@Haroon-Khel Haroon-Khel commented Feb 16, 2024

  • commit message has one of the standard prefixes
  • faq.md updated if appropriate
  • other documentation is changed or added (if applicable)
  • playbook changes run through VPC or QPC (if you have access)
  • VPC/QPC not applicable for this PR
  • for inventory.yml changes, bastillion/nagios/jenkins updated accordingly

fedora 33 and 34 are out of support https://docs.fedoraproject.org/en-US/releases/eol/
Alpine 312, 313 and 314 are out of support https://endoflife.date/alpine

The running containers will be replaced without the latest versions of both OSs, alpine 319 and fedora39

@Haroon-Khel
Copy link
Contributor Author

The dockerstatic checker workflow will fail for the removed OSs

@sxa
Copy link
Member

sxa commented Feb 16, 2024

The dockerstatic checker workflow will fail for the removed OSs

Surely they should be removed from https://github.com/adoptium/infrastructure/blob/master/.github/workflows/check_dockerstatic.yml in this PR too?

@Haroon-Khel
Copy link
Contributor Author

I was saving it for another pr but yeah it makes sense to do it here

@github-actions github-actions bot added ghActions GitHub Actions docker and removed docker labels Feb 16, 2024
@github-actions github-actions bot added docker and removed docker labels Feb 16, 2024
@karianna
Copy link
Contributor

Should old Ubuntu versions also go?

@Haroon-Khel
Copy link
Contributor Author

Haroon-Khel commented Feb 19, 2024

I believe the out of date ubuntu distros are being discussed here #3393. Their removal can be saved for another pr

@sxa
Copy link
Member

sxa commented Feb 19, 2024

Should old Ubuntu versions also go?

I believe the out of date ubuntu distros are being discussed here #3393. Their removal can be saved for another pr

That's more about defining a policy and setting appropriate process in place going forward. We should certainly look at removing any old Ubuntu containers that we have at Temurin.

While I could be convinced either way I think we should leave the LTS Dockerfiles in the repository as long as Temurin can still run on them, especially since even Ubuntu 16.04 still has extended support if customers wish to pay Canonical for it until 2026 so is still viable if a customer with a suitable contract wished to use these dockerfiles to run an AQA suite. That would not be the case for the Fedora/Alpine versions being targeted by this PR.

Copy link
Contributor

@steelhead31 steelhead31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Haroon-Khel Haroon-Khel merged commit 8c2720b into adoptium:master Feb 19, 2024
11 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants