Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added jtreg-buffer testsuite #5308

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

judovana
Copy link
Contributor

based on:
#5195
#5167

@judovana
Copy link
Contributor Author

functional/jtreg-buffer/README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@karianna karianna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to understand why :-)

Co-authored-by: Martijn Verburg <martijnverburg@gmail.com>
@judovana
Copy link
Contributor Author

judovana commented May 14, 2024

Need to understand why :-)

Yah. That it honest question, and not easy one indeed! Various reasons, from dummy ones like: Original author quit, original author forget, original author was lazy or simply not brave enough to push it. And later, no one had time to take it over. Not exactly an good excuse, but is covering about half of the tests. I would silently nod in agreeing to anybody refusing to accept this test set for this reason. But I tried to do quite a few in past, and burned out on it. Other reasons are weird corner cases, which do not run everywhere. Most of them are currenly labeled as var.rh.jdk although better would be rhel.and.fedora. Others may get this label once I see them to fail on some Adoptium combination I had not yet tried. Some have security manager. And as that is going to be dropped, but not dropped, or at least not soon, usptream is not accepting new tests with SM. Soem of them were upstreamed in form, that the intersection of covered code was not identical, or illegible for backport. So we decided to keep also orignal version (see speed)
Main of all is speed. upstreaming test is sometimes lengthy (and triple it when you porting it down to the JDK where you need it most), and if one need a testcase asap... That is actually why this repo was ever created. Howerv... from there, is it super easy to slip... goto "dummy ones"; And thats why it is not empty, but actually grown a bit.

@judovana
Copy link
Contributor Author

I had recalled, that I was tracking the upstreaming. Its part of the repo, you can see it via githubhack: https://rawcdn.githack.com/rh-openjdk/jtreg-buffer/581161a13dd731f9eac1f89e5164884a77465bca/dupes.html

the removed are the tests which were upstreamed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants