Update customUrl to dynamically use Jenkins domain #5289
Conversation
buildenv/jenkins/JenkinsfileBase
Outdated
| jenkinsDomain = "openj9-jenkins.osuosl.org" | ||
| } | ||
| def customUrl = "https://${jenkinsDomain}/job/test.getDependency/lastSuccessfulBuild/artifact/" | ||
| echo "Custom URL: ${customUrl}" |
There was a problem hiding this comment.
Please create a function for this. We should not duplicate the code.
There was a problem hiding this comment.
Created function to avoid duplicate code.
Grinder link:
https://hyc-runtimes-jenkins.swg-devops.com/job/Grinder/40359/
There was a problem hiding this comment.
Can we move echo "Custom URL: ${customUrl}" in getCustomUrl()?
There was a problem hiding this comment.
Yes, moved it into getCustomUrl().
There was a problem hiding this comment.
|
Please run a Grinder via Adoptium Jenkins https://ci.adoptium.net/view/Test_grinder/job/Grinder/ |
|
@smlambert could you grant Anna access to Adoptium Grinder? She needs to run some PR testing. Thanks |
|
@annaibm - you should see a GitHub invitation to a test-triage team, once you accept it, you will have access to run Grinder jobs at ci-adoptium.net |
|
@ShelleyLambert I have received the invitation and accepted it. I could run the Grinder job. Thanks! |
|
|
https://openj9-jenkins.osuosl.org/view/Test/job/Grinder/3570/ |
|
@annaibm can you move this out of draft? Thanks |
- Dynamically build the customUrl using the extracted domain using getJenkinsDomain() resolves:adoptium#5286 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
There was a problem hiding this comment.
This LGTM, though you may want to consider a more specific method name than getCustomUrl(), as it is really getCustomUrlForLastSuccessfulArtifacts()
I could envision a future scenario, where we'd want to build other custom Jenkins links. The name can be updated when/if those scenarios arise.
resolves:#5286