New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorporate the disabled_tests scripts into PR check #4681
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hi @Ndacyayisenga-droid - let's put this formatting check into its own workflow file called verifyExcludeFiles.yml
We ultimately want to look at a PR, see if anything in the openjdk/excludes and/or called playlist.xml. Here is a guess at the snippet to use for a trigger...
pull_request:
# Sequence of patterns matched against refs/heads
branches:
paths:
- 'openjdk/excludes'
- 'playlist.xml'
The tricky part will be to test this type of change (see issue: #3920). We often put a workflow file into a personal repo and try to test it there first as a way to get around the difficulty of testing them before merging.
@smlambert how does this look like
|
@smlambert do we just need to verify whether the exclude files exist as the logic??? i.e
|
Incorporate the disabled_tests scripts into PR check
Fixes #3917
cc @ShelleyLambert @hendrikebbers