Added system test pre-stage jars #533
Conversation
annaibm
force-pushed
the
prestageSystemJar
branch
from
5242093
to
7a1d0ca
Compare
scripts/getDependencies.pl
Outdated
| mauve => { | ||
| url => 'https://ci.adoptium.net/job/systemtest.getDependency/lastSuccessfulBuild/artifact/systemtest_prereqs/mauve/mauve.jar', | ||
| fname => 'mauve.jar', | ||
| sha1 => '8ed5b172be6a8885b72d0015f44e2a0b6c172d47' |
There was a problem hiding this comment.
systemtest.getDependency builds mauve. The sha1 will be different in every build. We will need to ignore the sha1. The same as tools.
we do not need to ignore checksum for all systemtests jars
There was a problem hiding this comment.
This has not been addressed.
We should not ignore checksum for all systemtests jars. It means line 329 my $ignoreChecksum = ($url =~ /systemtest.getDependency/); is wrong. Using mauve as an example, it should not have sha1. And we should update the logic to if sha1 or shaurl does not exist, ignore checksum.
There was a problem hiding this comment.
@llxia I have updated the line to address the logic to if sha1 or shaurl does not exist, ignore checksum as below.
my $ignoreChecksum = (!defined $sha1 || $sha1 eq '') && (!defined $shaurl || $shaurl eq ''); .
annaibm
force-pushed
the
prestageSystemJar
branch
from
7a1d0ca
to
8d3c4a9
Compare
smlambert
changed the title
annaibm
force-pushed
the
prestageSystemJar
branch
6 times, most recently
from
30ac418
to
dc21e7b
Compare
annaibm
force-pushed
the
prestageSystemJar
branch
4 times, most recently
from
054cf64
to
7681dcc
Compare
annaibm
force-pushed
the
prestageSystemJar
branch
4 times, most recently
from
e9dab5b
to
f046b76
Compare
- Enables to avoid system test prerequisite zip file being empty. related: adoptium/aqa-tests#4912 Signed-off-by: Anna Babu Palathingal <anna.bp@ibm.com>
annaibm
force-pushed
the
prestageSystemJar
branch
from
f046b76
to
134e3fd
Compare
related: adoptium/aqa-tests#4912