[WIP] Updates #95
Closed
[WIP] Updates #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mwisner this is awesome! Thank you for taking the time to do this 😸 |
|
@offirgolan my pleasure! Would you prefer me to wait until the partial issues are fixed in ember or try and work out a refactor that doesn't use partials? I know that in ember slack generally speaking it seems people frown upon using partials, but at the same time in the demo app it seems like a valid use case at least to me... |
|
@mwisner totally up to you. If you want to get this in asap, then you can just convert the partial to a component. |
|
Closing in favor of #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades all dependencies to their latest versions.
TODO:
-- Replace jshint with eslint
-- Wait for upstream fix for (emberjs/ember.js#15621) or come up with work around. Currently menu items are not rendered in the demo as a result.