feat: do not run assets bundler when explicitely disabled in rc file #4429
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users can now totally disable the assets bundler logic integrated in the assembler, and this from the RCFile :
This is useful in our case, because with the next Vite integration, adonisjs/vite itself will launch the vite dev server
One thing to note : It's weird to set
assetsBundler
to false when you want to use Vite. It's not logical at all for users who don't know about internals of Adonis. But for the moment, we don't have much choice. Later, if our new Vite integration is successful, we should be able to remove all asset bundling logic from the Assembler. And also, we should be able to remove thisassetsBundler
configuration property from the RC File.