Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple ext for bundlers config file #4130

Merged
merged 3 commits into from
Apr 24, 2023

Conversation

Julien-R44
Copy link
Member

Proposed changes

detectAssetBundlers doesn't detect vite if we are using vite.config.ts instead of vite.config.js for exemple

Same with webpack.config. Particularly annoying because we have to use webpack.config.cjs for V6 and ESM

@Julien-R44
Copy link
Member Author

Also included a fix for the encore buildCommand.
It has to be encore production otherwise we get this output :

image

Sorry I was a bit lazy to make another PR for this 😅 But let me know if needed

@Julien-R44
Copy link
Member Author

Somes tests seem flaky on Windows. I have the same behavior locally. I'm getting some EBUSY errors. I'll try to find out why

@thetutlage
Copy link
Member

Somes tests seem flaky on Windows. I have the same behavior locally. I'm getting some EBUSY errors. I'll try to find out why

Yeah, it is a very well known issue with Windows file system on CI/CD. I haven't found any way around yet.

@thetutlage thetutlage merged commit effd75f into next Apr 24, 2023
4 of 8 checks passed
@Julien-R44 Julien-R44 deleted the feat/multiple-ext-bundlers branch April 24, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants