FORMS-7599 forms spa #1058
Open
FORMS-7599 forms spa #1058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rismehta
reviewed
Mar 28, 2023
| #if($isFormsSpa) | ||
| componentGroup="${appTitle} - Adaptive Form"/> | ||
| #else | ||
| componentGroup=".${appTitle} - Adaptive Form"/> |
There was a problem hiding this comment.
We would expose form container in march release
There was a problem hiding this comment.
So should we keep it hidden in current release? How will the customer use it?
rismehta
reviewed
Mar 28, 2023
| @@ -26,6 +26,14 @@ | |||
| "react-router": "^5.1.2", | |||
| "regenerator-runtime": "^0.13.7", | |||
| #end | |||
| #if ($isFormsSpa) | |||
| "@aemforms/af-core": "^0.22.37", | |||
There was a problem hiding this comment.
Can you confirm with the PM team, if we should share sample for MUI here ?
rismehta
reviewed
Mar 28, 2023
|
|
||
| // submit error handler | ||
| form.subscribe((action) => { | ||
| const defaultSubmissionError = 'Error during form submission'; // todo localize this |
There was a problem hiding this comment.
We would need to add a small sample for localization here. Can you check with @amit-mnnit once ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: