Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SITES-21656] OOTB Experience Fragment Localization Issue for /eu/fr Site #2755

Merged
merged 2 commits into from
May 20, 2024

Conversation

alexandru-stancioiu
Copy link
Contributor

@alexandru-stancioiu alexandru-stancioiu commented May 16, 2024

Q                       A
Fixed Issues? https://jira.corp.adobe.com/browse/SITES-21656 and remove support for Java 8
Patch: Bug Fix?
Minor: New Feature? Allow to specify cq:isLanguageRoot=true and jcr:language="fr" on language root resource in order to force correct localization of XF link
Major: Breaking Change?
Tests Added + Pass? Yes
Documentation Provided Yes (code comments and or markdown)
Any Dependency Changes?
License Apache License, Version 2.0

Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

codecov bot commented May 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.17%. Comparing base (afb6dda) to head (bf71283).

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2755      +/-   ##
============================================
- Coverage     87.19%   87.17%   -0.03%     
  Complexity     2683     2683              
============================================
  Files           235      235              
  Lines          7170     7166       -4     
  Branches       1097     1094       -3     
============================================
- Hits           6252     6247       -5     
  Misses          363      363              
- Partials        555      556       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexandru-stancioiu alexandru-stancioiu merged commit d844a0e into main May 20, 2024
14 checks passed
@alexandru-stancioiu alexandru-stancioiu deleted the sites_21656 branch May 20, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants