WIP - Enable subdomain access for buckets #925
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afranken
force-pushed
the
144-subdomain-access-for-buckets
branch
from
7550de3
to
b151edb
Compare
BucketNameFilter will extract the bucket name from subdomain or path and add it as a request attribute for consumption in handler methods. Fixes #144
Trying out if this works (BucketNameFilter will take name from path), assert that bucket name is the same that is passed in the path to the handler method. Fixes #144
afranken
force-pushed
the
144-subdomain-access-for-buckets
branch
from
b151edb
to
5984ed0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BucketNameFilter will extract the bucket name from subdomain or path and add it as a request attribute for consumption in handler methods.
WIP - not sure yet how I can add this transparently so that handler methods work for both path and subdomain access.
BucketNameFilter will probably have to extract the ObjectKey as well, handler methods need to declare their path value so that it matches paths with and without buckets.
Maybe this will have to be configured at launch time.
Maybe it's not possible without breaking changes.
Related Issue
Fixes #144
Tasks