Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using list of characters instead of a string for Problem 24.8 #151 #152

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

deveshks
Copy link
Contributor

Updated code to use a list of characters instead of a string to represent an added word for Problem 24.8 in order to avoid the extra time complexity associated with string concatentations

$ python3.7 epi_judge_python_solutions/left_right_justify_text.py
Test PASSED (30/30) [ 15 us]
Average running time: 37 us

@deveshks
Copy link
Contributor Author

Hi @tsunghsienlee, @adnanaziz, @metopa

I have submitted a PR to outline my fix for issue #151.

Please review the same at your convenience and I will address any concerns with the same in the PR

@tsunghsienlee
Copy link
Collaborator

Generally it looks good to me, and I probably will omit get_strings function but it is definitely personal choice. This will be merge later.

@deveshks
Copy link
Contributor Author

deveshks commented May 9, 2020

Hi @tsunghsienlee

Hope you are doing well. I just saw that this PR has been sitting in an open state since a few months now. May I know when do you plan to merge this PR to master?

@metopa
Copy link
Collaborator

metopa commented Jun 7, 2020

@deveshks Hi there, sorry for the long wait. I'll check this out right after I do my state exams at the end of June. I'll keep you updated :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants