Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix over-eager rebuilding of rosrust_msg when nothing changed #201

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix over-eager rebuilding of rosrust_msg when nothing changed #201

wants to merge 1 commit into from

Conversation

DomWilliamsEE
Copy link

Fixes #176, where all files including inside .git are tracked by build.rs and triggers rebuilds too often.

@Alby407
Copy link

Alby407 commented Sep 26, 2023

Why has this not been merged so far?

@Alby407
Copy link

Alby407 commented Feb 15, 2024

@adnanademovic Could you check this PR and merge it?

@adnanademovic
Copy link
Owner

adnanademovic commented Feb 16, 2024 •
edited

Wouldn't this introduce the opposite problem where updates to the .msg file contents won't trigger an update?

I'd be OK with explicitly filtering out any .git folder, as that would make sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rosrust_msg takes a lot of time on each cargo build while messages definitions have not changed
3 participants
@DomWilliamsEE @Alby407 @adnanademovic