This repository has been archived by the owner on May 13, 2024. It is now read-only.
fix: update report billed flag to be like project billed flag #988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fix adfinis/timed#72 |
fugal-dy
reviewed
Feb 29, 2024
timed/tracking/views.py
Outdated
| @@ -267,8 +267,7 @@ def bulk(self, request): | |||
| if "task" in fields: | |||
| # unreject report if task has changed | |||
| fields["rejected"] = False | |||
| if fields["task"].project.billed: | |||
| fields["billed"] = fields["task"].project.billed | |||
| fields["billed"] = fields["task"].project.billed | |||
There was a problem hiding this comment.
This could set fields["billed"] to None which is not the same as False. Not sure if it would be appropriate to default fields["billed"] to False, similar to the above fields["rejected"]
There was a problem hiding this comment.
i make it sure that the value will be true or false
MitanOmar
force-pushed
the
update-report-billed-flag-to-be-like-project-billed-flag
branch
from
2baa0f5
to
eba561e
Compare
fugal-dy
approved these changes
Feb 29, 2024
c0rydoras
suggested changes
Apr 12, 2024
| @@ -267,8 +267,7 @@ def bulk(self, request): | |||
| if "task" in fields: | |||
| # unreject report if task has changed | |||
| fields["rejected"] = False | |||
| if fields["task"].project.billed: | |||
| fields["billed"] = fields["task"].project.billed | |||
| fields["billed"] = True if fields["task"].project.billed else False | |||
There was a problem hiding this comment.
Suggested change
| fields["billed"] = True if fields["task"].project.billed else False | |
| fields["billed"] = fields["task"].project.billed |
this should also work since its a boolean
There was a problem hiding this comment.
@c0rydoras that's where this started off at #988 (comment)
There was a problem hiding this comment.
fields["billed"] = bool(fields["task"].project.billed)There was a problem hiding this comment.
if it isn't a boolean this accomplishes the same
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.