-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add redis ssl support #787
base: master
Are you sure you want to change the base?
Conversation
I will look at this ASAP. |
@@ -11,6 +11,7 @@ | |||
"documents": { | |||
"db": os.environ.get("REDIS_DB_DOCUMENTS") or 1, | |||
}, | |||
"ssl": os.environ.get("REDIS_SSL") == 'True', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Boolean env vars are mostly 1/0. We should at least support 1,YES,TRUE (case insensitive).
WDYT?
If you want to use environement variables instead. Remove entry 'REDIS' in configuration file and use ENVIRONEMENTS variables : | ||
|
||
|
||
| Variable | require | Default | Descripion | example | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| Variable | require | Default | Descripion | example | | |
| Variable | require | Default | Description | example | |
| REDIS_SOCKET | false | | | | | ||
| REDIS_DB_INDEXES | true | 0 | | | | ||
| REDIS_DB_DOCUMENTS | true | 1 | | | | ||
| REDIS_SSL | false | | Acive SSL | True | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| REDIS_SSL | false | | Acive SSL | True | | |
| REDIS_SSL | false | | Active SSL | True | |
Add SSL option for redis.