Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert to using dayjs #146

Merged
merged 5 commits into from Aug 25, 2020
Merged

convert to using dayjs #146

merged 5 commits into from Aug 25, 2020

Conversation

jmsunseri
Copy link
Contributor

moment js is too bloated for my company to use in our projects but I really wanted to use your library so I forked it to remove that dependency. I left moment as a dev dependency so that I could validate that my changes matched your changes. I had to modify two test results because they relied on an assumption that the person running the test had a positive UTC offset I hope you don't mind.

Not knowing if you are at all interested in this work I modified some of the information in the package.json. If you are actually interested in merging this then I will revert those changes and update the pull request.

Thanks,
Justin

@adamgibbons
Copy link
Owner

@jmsunseri Always happy to help ICS drop some weight - so thank you for opening this PR. I haven't reviewed it carefully yet but looking at it briefly, 1) I see only upsides to using Day.js; 2) I want to remove the positive offset assumption (it's a bad assumption!). I just need to double-check that this is has backwards compatibility w/ 2.x. So - yes - plz remove the package.json changes and I'll merge this in asap. Thanks again for making this a leaner library!

@jmsunseri
Copy link
Contributor Author

I think that should do it.

@adamgibbons adamgibbons merged commit 18031ed into adamgibbons:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants