Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add query parameter languageCode to movie details endpoint #173

Closed
wants to merge 1 commit into from

Conversation

armintelker
Copy link

I am not sure if I have done everything correct.
The details endpoint for movies is missing the language endpoint
I have added it.

@adamayoung
Copy link
Owner

@armintelker Thanks for the PR.

This issue seems odd. The language code is added to ALL requests in the APIClient
https://github.com/adamayoung/TMDb/blob/17d8acefb41cd33b423357a831d4126aea6f4fa2/Sources/TMDb/Networking/TMDbAPIClient.swift#L123C32-L123C59

And the language code comes from here

var languageCode: String? {

Can you double check this is behaving correctly, and it's not just an issue on fetching movie details?

@armintelker
Copy link
Author

@adamayoung
Hey maybe I am understanding it wrong but how can I set the language code without changing the OS language? I am from Germany and I want to fetch the movie details in English and German. I have searched in the documentation and the code but everything that would help me to change the language code is not public and only accessible inside the library.

@adamayoung
Copy link
Owner

Hi @armintelker. I'm going to close this PR in favour of this one #176 which adds the ability to add language (and region/country) to all methods which have it available from TMDb.

@adamayoung adamayoung closed this May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants