Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drm added for PiTFT 3.5" resistive #311

Merged
merged 2 commits into from
May 22, 2024

Conversation

mikeysklar
Copy link
Contributor

The PiTFT 3.5" resistive display requires a drm flag to work with Pi Zero and 3B versions of Bookworm. Tested on Pi4 and Pi5 as well.

The PiTFT 3.5" resistive display requires a drm flag to work with Pi Zero and 3B versions of Bookworm. Tested on Pi4 and Pi5 as well.
@mikeysklar
Copy link
Contributor Author

Only applying the 'drm' flag for the model display I've tested on. This could be needed for other PiTFT models to work well with Bookworm on certain Raspberry Pi models.

@makermelissa
Copy link
Contributor

Unfortunately, this blanket approach will most likely break several other boards. Currently this is added in https://github.com/adafruit/Raspberry-Pi-Installer-Scripts/blob/main/adafruit-pitft.py#L426-L427 when tinydrm_install is set to True in update_configtxt(). This is called from https://github.com/adafruit/Raspberry-Pi-Installer-Scripts/blob/main/adafruit-pitft.py#L905 and is set to True if wayland is detected. It appears that they changed it in kernel 6.6 so that it can be bookworm, not wayland, and needs drm. So maybe trychanging line 905 to if not update_configtxt(tinydrm_install=(not is_bullseye)):

@mikeysklar
Copy link
Contributor Author

Okay, thank you for pointing this out. I'll make some changes and try the modified code on Bullseye and Bookworm.

switch to tinydrm_install logic
@mikeysklar
Copy link
Contributor Author

mikeysklar commented May 3, 2024

Made suggested changes. Worked well on the following Pi's with a 3.5" resistive touch display.

Pi5 : 3/15/24 Bookworm + Updates
Pi3B : 3/15/24 Bookworm + Updates
Pi4 : Legacy Bullseye 32-bit + Updates

Note Legacy Bullseye does not add the drm line to the dtoverlay. X and touch both work well without it.

Copy link
Contributor

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.

@makermelissa makermelissa merged commit 7b6fced into adafruit:main May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants