Duplicate definition of InterruptLock on ESP8266 #135
Conversation
dok-net
force-pushed
the
master
branch
2 times, most recently
from
708bbc6
to
2cea6e7
Compare
|
hi travis is not passing @dok-net do you know why? |
|
It's not building against ESP8266 Arduino master branch, is it? The namespace fix for esp8266::InterruptLock is in esp8266/Arduino@f5a882d Dependency hells all over the place. |
|
we test against release, that's what everyone's got :) |
|
Yeah, except, when I got my first ESP8266, the documentation strongly suggested to get the esp8266-community framework direct from git, and that usually gives you the master branch, more precisely, the HEAD of that. Now here we are... |
|
may be...but 99% of people using ESP8266 don't - they use the BSP manager built into arduino. |
|
Dependency hell... 2019... OMG... but never mind, I've reverted the premature alignment to master HEAD; mea culpa. Please remember/remind me/allow me to PR once time comes and ESP8266 Arduino releases next time. Thanks for all those invaluable hardware libraries! By the way, there's still some other PRs of mine pending heh heh |
|
as you can see, we have hundreds of libraries, and PRs are not trivial to merge. they take many hours to analyze and vet. you can help get PRs merged by testing/vetting other PR's! |
|
Good to know! |
|
2.6.0 is released, please retest. |
…p8266/interrupts.h there.
… of InterruptLock." Until next release of ESP8266 Arduino, the accompanying fix for the same issue there is not available to use - undo this revert when time comes. This reverts commit 65b884a.
The InterruptLock exists in cores/esp8266/interrupts.h in ESP8266 Arduino.