Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove result output in succeded tasks #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

danielmichalichyn
Copy link
Contributor

Description

In this pull request I'm suggesting that we remove the result output when a task is succeded. If we need to print the result when a task is finished, we can do a console.info/.log from the task.
Printing the result from the celery.node package, can create issues if we have a huge result output, and when we run this application in a Docker the container logs get flooded with a lot of useless information.

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Removing the result variable from a console.info.

  • What is the current behavior? (You can also link to an open issue here)
    Print all the result into the console of the application;

  • What is the new behavior (if this is a feature change)?
    Print only conclusion information about the task;

@actumn
Copy link
Owner

actumn commented May 27, 2021

Hi, @danielmichalichyn!
Always greatly appreciated this awesome PR!

But in this case, I'm not sure it is really required for us.
We should hear other user's voices.

@bitcranos
Copy link

Hi @actumn ,
I believe @danielmichalichyn is right. If the worker's function is handling personal sensitive information (ie: tax id, Social Security number etc...), you don't want to have them logged and potentially available for other teams/people to see (es: sys admin, ops team, etc...).
Maybe, instead of removing the result variable for all worker's functions, it can be handled with an optional parameter to add when a function is registered into a worker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants