Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support partial manual routing #100

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

comfuture
Copy link

Description

Partially solved the problem that the queue name and routingKey determined at the time of client creation cannot be changed.

Due to the design of the current code, queue and routingKey are treated as same. Therefore, I only added an option to change the routingKey when creating a task or when sending a task message.

const task = client.createTask("tasks.multiply", { routingKey: "my_queue" });
const result = task. applyAsync([2, 3]);

or

const task = client. createTask("tasks. multiply");
const result = task.applyAsync([2, 3], undefined, { routingKey: "my_queue" });
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

    Enhancement

  • What is the current behavior? (You can also link to an open issue here)

    The queue name and routingKey determined at the time of client creation cannot be changed after creation.
    Related: Support manual routing. #94

  • What is the new behavior (if this is a feature change)?

    Each tasks can have their own routingKey

@abhikb101
Copy link

@actumn Hi, just wanted to know if this PR will get merged soon? Our usecase requires manual routing so it would help if this gets merged in the original branch instead of us making a seperate Package from this branch. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants