-
Notifications
You must be signed in to change notification settings - Fork 169
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Signal icon to Modal Share page #855
base: main
Are you sure you want to change the base?
Add Signal icon to Modal Share page #855
Conversation
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. It'd be great to have you! Maintainer checklist
|
@@ -196,6 +200,7 @@ import type { Group } from "~/types/group"; | |||
import type { Organization } from "~/types/organization"; | |||
import type { Resource } from "~/types/resource"; | |||
import type { User } from "~/types/user"; | |||
import IconSignal from "../icon/IconSignal.vue"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In Nuxt we actually don't need to import the components, so this can be removed (regardless of us not using a component anyway) 😊
@@ -0,0 +1,10 @@ | |||
|
|||
<template name="iconsignal"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually don't need this component, @Mister-Tofu-tech :) My suggestion would be to use the built in <Icon />
component via Nuxt Icon. You can pass in an icon that you find on Icones in the following way, with simple-icons:signal
being one I'd suggest:
<Icon name="simple-icons:signal" size="1.5em" />
This can be directly dropped into ModalSharePage
. We do not need a separate component for it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Mister-Tofu-tech 👋 Given the changes recently in #868, the code for this would now be:
<Icon :name="IconMap.SIGNAL" size="1.5em" />
Once you do the changes above, @Mister-Tofu-tech, check out the contributing guide for extensions that you can add that will format your code with Prettier. This will then clear up the test error that we're getting here. From there, @GrandSuccess87 and I can look into what the links for this can be, and we can pass on some info on what the next steps are! 🚀 |
Contributor checklist
Description
Related issue