Revert a change made in 2014 that prevent Ransack from finding the co… #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add a test for this change? |
|
@michaelrobinette thanks for this PR. Can you add some explanation as to why it is needed, and a test would be awesome. |
|
@michaelrobinette if we had a passing test for this we could merge it. |
|
Closing as stale |
|
Reopening: I'll rebase this and add a test. |
|
Took a look at this, the tests are green with the code merged, but we need a bit more detail before proceeding with it:
Removing this from the 3.0.0 Release and adding the Blocked label until these points can be addressed. |
scarroll32
force-pushed
the
main
branch
5 times, most recently
from
f8fb6e2
to
a02daba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rrect DB