Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: continue flow on pause #4651

Merged
merged 10 commits into from May 9, 2024
Merged

fix: continue flow on pause #4651

merged 10 commits into from May 9, 2024

Conversation

islamaf
Copy link
Collaborator

@islamaf islamaf commented May 9, 2024

What does this PR do?

Fixes the flow not updating in the UI after successful/failure of flow.

@islamaf islamaf requested a review from abuaboud May 9, 2024 00:12
Copy link

nx-cloud bot commented May 9, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit facba8e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx run-many --target=test --projects=engine,shared,server-api --parallel=3
nx affected --target=lint --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@islamaf islamaf self-assigned this May 9, 2024
@islamaf islamaf changed the title fix: ontinue flow on pause fix: continue flow on pause May 9, 2024
packages/server/api/src/app/flows/flow.module.ts Outdated Show resolved Hide resolved
packages/server/api/src/app/flows/flow.module.ts Outdated Show resolved Hide resolved
packages/server/api/src/app/flows/flow.module.ts Outdated Show resolved Hide resolved
@abuaboud abuaboud marked this pull request as ready for review May 9, 2024 13:51
abuaboud
abuaboud previously approved these changes May 9, 2024
@abuaboud abuaboud added 🐛 bug Something isn't working auto-deploy labels May 9, 2024
@abuaboud abuaboud dismissed their stale review May 9, 2024 13:54

The merge-base changed after approval.

@abuaboud abuaboud force-pushed the fix/continue-flow-on-pause branch from 1872268 to b16503a Compare May 9, 2024 13:54
@abuaboud abuaboud merged commit 8f00e13 into main May 9, 2024
10 of 12 checks passed
@abuaboud abuaboud deleted the fix/continue-flow-on-pause branch May 9, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-deploy 🐛 bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants