Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: piece form #4205

Merged
merged 106 commits into from Mar 25, 2024
Merged

refactor: piece form #4205

merged 106 commits into from Mar 25, 2024

Conversation

AbdulTheActivePiecer
Copy link
Collaborator

No description provided.

AbdulTheActivePiecer and others added 30 commits March 13, 2024 14:17
@AbdulTheActivePiecer
chore: add actions/triggers dropdown component
5f76802
@AbdulTheActivePiecer
chore: move mat pseudo checkbox to common
222050b
@AbdulTheActivePiecer
chore: remove unnecessary code
9fc5031
@AbdulTheActivePiecer
chore: add dynamic input toggle
d35252a
@AbdulTheActivePiecer
chore: add dropdown search control component
48e0c04
@AbdulTheActivePiecer
chore: add static dropdown component
105542c
@AbdulTheActivePiecer
chore: handle static multi select dropdowns
90c34b3
@AbdulTheActivePiecer
chore: added connections dropdown
455b233
@AbdulTheActivePiecer
chore: add option to disable local search in dropdowns search pipe wh…
f4d9219 
…en search is handled by backend
@AbdulTheActivePiecer
chore: reformat code
e68933c
@AbdulTheActivePiecer
chore: trigger change detection in case a user adds new connection or…
d4ed8b8 
… reconnects an old one
@AbdulTheActivePiecer
chore: add dropdown labels joiner pipe
428c16d
@AbdulTheActivePiecer
chore: introduce core refreshable property control
073238a
@AbdulTheActivePiecer
chore: create refreshable dropdown control
71e7c1d
@AbdulTheActivePiecer
chore: use labels joiner in static dropdown for select trigger
f05ac48
@AbdulTheActivePiecer
chore: add loading spinner to refreshable dropdowns
2156d20
@AbdulTheActivePiecer
chore: add initial dynamic property control
0808e4d
@AbdulTheActivePiecer
chore: introduce json control
a7a3908
@AbdulTheActivePiecer
chore: introduce control description
f3b028e
@AbdulTheActivePiecer
fix: builder autocomplete imports
592bb4e
@AbdulTheActivePiecer
chore: rename formControl to passedFormControl so it doesn't conflict…
7d03677 
… with fromControl directive
@AbdulTheActivePiecer
chore: introduce text-control
b9cfa67
@AbdulTheActivePiecer
fix: name json control component correctly
9dbeb25
@AbdulTheActivePiecer
chore: introduce checkbox component
d3677a6
@AbdulTheActivePiecer
chore: expose JsonProperty
673ceea
@AbdulTheActivePiecer
fix: rename connections dropdown selector correctly
3a63410
@AbdulTheActivePiecer
fix: use correct type for property in json control
557832d
@AbdulTheActivePiecer
chore: add pipe to cast AbstractController to UntypedFormControl
7279834
@AbdulTheActivePiecer
fix: change passed control type in text control
ecbd9a2
@AbdulTheActivePiecer
chore: introduce initial new piece properties form
c8b4a60
@AbdulTheActivePiecer
Copy link
Collaborator Author

Tests Performed: [Passed] Google Sheets -> Fill Spread sheet via Dynamic value -> Confirm Sheet Dropdown loaded [Passed]: Fill props in Branch Piece -> Save -> Refresh -> Confirm they are there. [Passed]: Slack -> Reconnect -> Dropdown Loaded Correctly -> Fill Message -> Refresh -> Confirm they are there [Passed]: Gmail -> Filled Connection -> CC Array / To Array -> Send Test confirm it worked [FAILED]: Markdown starts to show at the end. It used to be first. Check Google Sheets for new row / New Form Triggers. It should show at first or in the original props order. [Passed]: Google Sheets -> New Row -> Refreshers work for dropdown -> Load Data Works [Passed]: Google Sheets -> Insert Row -> Dynamic dropdown loaded -> Insert data. It works. [Passed]: Change "Wait for Response" in Form Trigger / Fill Array of Objects -> It saved (Confirmed after refresh).

Fixed.

khaledmashaly
khaledmashaly reviewed Mar 22, 2024
View reviewed changes
.prettierrc Show resolved Hide resolved
packages/ui/common/src/lib/components/control-description/control-description.component.ts Show resolved Hide resolved
...ponents/action-error-handling-form-control/action-error-handling-form-control.component.html Show resolved Hide resolved
...ponents/action-error-handling-form-control/action-error-handling-form-control.component.html Show resolved Hide resolved
...ponents/action-error-handling-form-control/action-error-handling-form-control.component.html Show resolved Hide resolved
...m-controls/src/lib/components/dictionary-form-control/dictionary-form-control.component.html Show resolved Hide resolved
...m-controls/src/lib/components/dictionary-form-control/dictionary-form-control.component.html Show resolved Hide resolved
...orm-controls/src/lib/components/dropdown-search-control/dropdown-search-control.component.ts Show resolved Hide resolved
...lder-form-controls/src/lib/components/dynamic-input-toggle/dynamic-input-toggle.component.ts Show resolved Hide resolved
...r/src/lib/edit-step-sidebar/edit-step-form-container/edit-step-form-container.component.html Show resolved Hide resolved
@AbdulTheActivePiecer AbdulTheActivePiecer marked this pull request as ready for review March 22, 2024 20:22
@AbdulTheActivePiecer AbdulTheActivePiecer self-assigned this Mar 25, 2024
@abuaboud abuaboud merged commit b898e0a into main Mar 25, 2024
11 of 12 checks passed
@khaledmashaly khaledmashaly deleted the reafctor/piece-form branch April 1, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abuaboud abuaboud abuaboud requested changes

@khaledmashaly khaledmashaly khaledmashaly left review comments

Assignees

@AbdulTheActivePiecer AbdulTheActivePiecer

Labels
auto-deploy skip-changelog
Projects
No open projects
Sprint (18th March - 26th March)
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@AbdulTheActivePiecer @abuaboud @khaledmashaly