New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: delay to next weekday/day of year #3404
base: main
Are you sure you want to change the base?
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 48a4760. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following target is in progress ✅ Successfully ran 2 targetsSent with 💌 from NxCloud. |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit ba5f151. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ⌛ The following targets are in progress
✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
Hi @joeworkman Thank you for the PR, I believe this should be achieved through data helper and use delay until. The other way is using inline functions #1018 when it's released I am closing this pr, please feel free to reopen. |
@abuaboud My original thought was to use date helper and delay until. But then I thought... why require the use of 2 tasks when we can do it all in one? I think many people will not think about using the date helper action with delay until. This makes sense to me. |
@joeworkman I think in-line functions feature will solve these issues will keep the pr open until we finish scooping inline functions and check if it solves the problem or not |
@abuaboud Curious on the status on this. Have inline functions been implemented? Where can I learn more about what that is? |
What does this PR do?
This adds 2 new actions to the Delay piece:
I did centralize a
delayUntil
function that was used inside of thedelay-until-used
action.