Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: delay to next weekday/day of year #3404

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

joeworkman
Copy link
Contributor

What does this PR do?

This adds 2 new actions to the Delay piece:

  • Delay the workflow until the next day or the week at a specific time.
  • Delay the workflow until the next day or the year at a specific time.

I did centralize a delayUntil function that was used inside of the delay-until-used action.

Copy link

nx-cloud bot commented Dec 11, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 48a4760. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following target is in progress

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

nx-cloud bot commented Dec 14, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit ba5f151. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


⌛ The following targets are in progress

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@abuaboud
Copy link
Contributor

abuaboud commented Jan 4, 2024

Hi @joeworkman

Thank you for the PR, I believe this should be achieved through data helper and use delay until.

The other way is using inline functions #1018 when it's released

I am closing this pr, please feel free to reopen.

@abuaboud abuaboud closed this Jan 4, 2024
@joeworkman
Copy link
Contributor Author

joeworkman commented Jan 4, 2024

@abuaboud My original thought was to use date helper and delay until. But then I thought... why require the use of 2 tasks when we can do it all in one? I think many people will not think about using the date helper action with delay until. This makes sense to me.

@abuaboud abuaboud reopened this Jan 4, 2024
@abuaboud
Copy link
Contributor

abuaboud commented Jan 5, 2024

@joeworkman I think in-line functions feature will solve these issues will keep the pr open until we finish scooping inline functions and check if it solves the problem or not

@abuaboud abuaboud added the 🤷‍♂️ action required Further action or information required label Jan 5, 2024
@joeworkman
Copy link
Contributor Author

@abuaboud Curious on the status on this. Have inline functions been implemented? Where can I learn more about what that is?

@abuaboud abuaboud added blocked dependent on another issue and removed 🤷‍♂️ action required Further action or information required labels Apr 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked dependent on another issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants