Improved message for GetChunkError #2844
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khustup2
approved these changes
May 7, 2024
activesoull
approved these changes
May 7, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
馃殌 馃殌 Pull Request
Impact
Description
Includes the "root cause" reason for a GetChunkError in the error message.
Things to be aware of
If the root cause is a GetChunkError also, it goes further up the chain
Things to worry about
The string versions of exceptions are not always good and may not be helpful. For example, the KeyError I tested with only listed the key with no other information. Other random causes for GetChunkError may be more helpful, or not