Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improves S3 retry logic #2834

Merged
merged 3 commits into from Apr 29, 2024
Merged

Improves S3 retry logic #2834

merged 3 commits into from Apr 29, 2024

Conversation

nvoxland-al
Copy link
Contributor

馃殌 馃殌 Pull Request

Impact

  • Bug fix (non-breaking change which fixes expected existing functionality)
  • Enhancement/New feature (adds functionality without impacting existing logic)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description

  • Increases the minimum number of retries
  • Retry on ssl.SSLException
  • Backoff retry time on SSLExceptions

Things to be aware of

Only adds backoff logic for SSLExceptions at this point

nvoxland and others added 3 commits April 27, 2024 02:48
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 27, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
30.6% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@nvoxland-al nvoxland-al merged commit 482a340 into main Apr 29, 2024
8 of 10 checks passed
@nvoxland-al nvoxland-al deleted the retry_handling branch April 29, 2024 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@activesoull activesoull activesoull approved these changes

@khustup2 khustup2 khustup2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@nvoxland-al @activesoull @khustup2 @nvoxland