Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for audio/video support in hub.ingest #2072

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

aadityasinha-dotcom
Copy link
Contributor

馃殌 馃殌 Pull Request

Checklist:

  • My code follows the style guidelines of this project and the Contributing document
  • I have commented my code, particularly in hard-to-understand areas
  • I have kept the coverage-rate up
  • I have performed a self-review of my own code and resolved any problems
  • I have checked to ensure there aren't any other open Pull Requests for the same change
  • I have described and made corresponding changes to the relevant documentation
  • New and existing unit tests pass locally with my changes

Changes

Resolves #1556

@aadityasinha-dotcom
Copy link
Contributor Author

@FayazRahman can you review this?

@istranic
Copy link
Contributor

Hi @aadityasinha-dotcom Apologies for taking so long to respond to your PR. Are you still available to continue this work?

@aadityasinha-dotcom
Copy link
Contributor Author

@istranic yes!!

@istranic
Copy link
Contributor

istranic commented Jan 13, 2023

@aadityasinha-dotcom ok great. I think next steps are:

@istranic
Copy link
Contributor

Also @aadityasinha-dotcom is there a way to make this work will all file types that are supported in deeplake, not just audio+video?

@istranic
Copy link
Contributor

Also @aadityasinha-dotcom Can you rename the function to ingest_classification, and implement parallel uploading using deeplake.compute. An example for similar datasets is here - You can also see more complex implementation in ingest_yolo and ingest_coco

I'm asking this because we're focusing a lot more on speed, reliability, and scale, so everything needs to work with bigger workloads.

@istranic
Copy link
Contributor

Hey @aadityasinha-dotcom How's the progress on this PR. This is becoming quite high-priority internally, so just want to confirm it's moving along. If not, the current progress on this PR is really helpful, and our team can cake over and add some of the modifications I requested above.

@aadityasinha-dotcom
Copy link
Contributor Author

aadityasinha-dotcom commented Jan 23, 2023

Hey @istranic, sorry been busy last week. I have worked on adding the tests and yes, it will be helpful if someone can do modifications.
If you got any task for me, I am ready to work on it.

@istranic
Copy link
Contributor

@aadityasinha-dotcom Got it, thx for the update.

@aadityasinha-dotcom
Copy link
Contributor Author

@istranic anything else left in this PR?

@istranic
Copy link
Contributor

istranic commented Feb 23, 2023

Hey @istranic, sorry been busy last week. I have worked on adding the tests and yes, it will be helpful if someone can do modifications. If you got any task for me, I am ready to work on it.

@ProgerDav Can you pls look at this PR, since it's related to work you've been doing.

How come full tests aren't running.

deeplake/api/dataset.py Show resolved Hide resolved
deeplake/api/dataset.py Show resolved Hide resolved
deeplake/api/dataset.py Outdated Show resolved Hide resolved
deeplake.ingest(
src=path, dest=path, progressbar=False, summary=False, overwrite=False
)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In line 183 it says memory_path is not defined

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe because of the undeclared variable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] hub.auto for audio and video htypes
2 participants