Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] hub.auto for audio and video htypes #1556

Open
2 tasks
FayazRahman opened this issue Mar 19, 2022 · 13 comments 路 May be fixed by #2072
Open
2 tasks

[FEATURE] hub.auto for audio and video htypes #1556

FayazRahman opened this issue Mar 19, 2022 · 13 comments 路 May be fixed by #2072
Assignees
@aadityasinha-dotcom
Labels
enhancement New feature or request
Projects
New Contributor projects

Comments

@FayazRahman
Copy link
Contributor

馃毃馃毃 Feature Request

  • Related to an existing Issue
  • A new implementation (Improvement, Extension)

Is your feature request related to a problem?

Extend hub.auto to enable ingesting audio and video data. Take a look at ingesting image datasets for a start.

Description of the possible solution

Adding a video_ingestion.py file to hub/auto/unstructured with necessary changes would work. But this might mean rewriting a lot of code as in image_classification.py

An alternative solution to the problem can look like

To avoid this, a general class could be written and used as base class for image, audio and video.
@FayazRahman FayazRahman added enhancement New feature or request good first issue Good for newcomers labels Mar 19, 2022
@FayazRahman FayazRahman added this to Medium tasks in New Contributor projects Mar 19, 2022
@neel2299
Copy link
Contributor

Can I work on this issue ??

@FayazRahman
Copy link
Contributor Author

@neel2299 Of course. I'll assign it to you.

@neel2299
Copy link
Contributor

neel2299 commented Mar 29, 2022 •
edited

Hello!! Can we add dependencies to get the video/audio meta data ?? @FayazRahman @farizrahman4u @mikayelh

@farizrahman4u
Copy link
Contributor

farizrahman4u commented Apr 3, 2022 •
edited

Hello!! Can we add dependencies to get the video/audio meta data ?? @FayazRahman @farizrahman4u @mikayelh

No, hub already has all the dependencies required for reading meta data from audio and video.

@farizrahman4u
Copy link
Contributor

farizrahman4u commented Apr 3, 2022 •
edited

Also note that we are switching from miniaudio to PyaAV for audio in this PR : #1576 , so it would be ideal if you base your PR against it.

@vaibhavjack11
Copy link

I am Interested to work on this issue

@neel2299
Copy link
Contributor

neel2299 commented Apr 5, 2022 •
edited

Noted, Thanks for the heads up. I will check the PR out.

@neel2299 neel2299 mentioned this issue May 1, 2022
Closed
7 tasks
@aryatalathi
Copy link

I would like to contribute to this issue. Can you please elaborate?

@mikayelh
Copy link
Collaborator

mikayelh commented Sep 8, 2022

hi @aryatalathi, do you prefer working on this issue or the datase tupload issue? I would recommend working on one issue at a time.

@aryatalathi
Copy link

Yeah, sure! I will prefer the dataset upload issue. Thank you!

@mikayelh
Copy link
Collaborator

mikayelh commented Sep 8, 2022

gotcha, good luck - let us know if you have any questions and hit me up in community slack for some guidance.

@aadityasinha-dotcom
Copy link
Contributor

Can I work on this?

@tatevikh
Copy link
Collaborator

Hi @aadityasinha-dotcom, go for it!

@aadityasinha-dotcom aadityasinha-dotcom linked a pull request Dec 22, 2022 that will close this issue
Open
7 tasks
@mikayelh mikayelh removed the good first issue Good for newcomers label Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aadityasinha-dotcom aadityasinha-dotcom

Labels
enhancement New feature or request
Projects
No open projects
New Contributor projects
Medium tasks
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for audio/video support in hub.ingest aadityasinha-dotcom/Hub
8 participants
@farizrahman4u @FayazRahman @mikayelh @vaibhavjack11 @aryatalathi @neel2299 @aadityasinha-dotcom @tatevikh