Update vendored jquery-ui from 1.12.1 to 1.13.3 #8329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3-0-stable #8329 +/- ##
=============================================
Coverage ? 99.19%
=============================================
Files ? 194
Lines ? 4945
Branches ? 0
=============================================
Hits ? 4905
Misses ? 40
Partials ? 0 ☔ View full report in Codecov by Sentry. |
tagliala
force-pushed
the
security/update-vendored-jquery-ui
branch
from
7e3715a
to
0c6df99
Compare
tagliala
force-pushed
the
security/update-vendored-jquery-ui
branch
2 times, most recently
from
8b3223a
to
3521927
Compare
JavaScript files have been manually updated because: - `jquery-ui-rails` is unmaintained and it is bundling 1.13.0 - An active fork of `jquery-ui-rails` is bundling 1.13.2, but there is a more recent version (1.13.3) `escape-selector` has been removed because jQuery UI is using jQuery's built-in escape selector. This selector is available from version 3.0, which is required by Active Admin, so it should not be a problem Ref activeadmin#8327 Ref: - https://bugs.jqueryui.com/ticket/14991/ - jquery/jquery-ui#1957
tagliala
force-pushed
the
security/update-vendored-jquery-ui
branch
from
3521927
to
44899a4
Compare
javierjulio
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JavaScript files have been manually updated because:
jquery-ui-railsis unmaintained and it is bundling 1.13.0jquery-ui-railsis bundling 1.13.2, but there isa more recent version (1.13.3)
escape-selectorhas been removed because jQuery UI is usingjQuery's built-in escape selector. This selector is available from
version 3.0, which is required by Active Admin, so it should not be
a problem
Ref #8327
Ref:
I've manually tested
$.ui.versionVersion in consolehttp://localhost:3000/admin/categories?order=name_aschttp://localhost:3000/admin/kitchensinkhttp://localhost:3000/admin/usershttp://localhost:3000/adminhttp://localhost:3000/admin/commentshttp://localhost:3000/admin/comments?order=id_deschttp://localhost:3000/admin/tagshttp://localhost:3000/admin/users