Artifact Stub

[thboop]

This is an example of what it would look like to deprecate an action using the runner. We would want to

• Add a feature flag
• Consolidate this into a single function to clean up the code
• determine what ref's should make it into an allowlist, and setup the code to handle those refs

[ChristopherHX]

Detecting by ref sounds to be a fragile detection method for me, however you can go with any approuch

I would check (actionDefinitionData.Execution as NodeJSActionExecutionData).NodeVersion == "node12" to detect v2 (v3 uses node16, v4 uses node20) together with the repository name

I would check for (actionDefinitionData.Execution as PluginActionExecutionData).Plugin == "publish" || (actionDefinitionData.Execution as PluginActionExecutionData).Plugin == "download" to detect v1 (uses an ancient runner plugin)

Inside

runner/src/Runner.Worker/ActionManager.cs

Lines 1006 to 1016 in 927b26a

	else if (actionDefinitionData.Execution.ExecutionType == ActionExecutionType.NodeJS)
	{
	Trace.Info($"Action node.js file: {(actionDefinitionData.Execution as NodeJSActionExecutionData).Script}, no more preparation.");
	return null;
	}
	else if (actionDefinitionData.Execution.ExecutionType == ActionExecutionType.Plugin)
	{
	Trace.Info($"Action plugin: {(actionDefinitionData.Execution as PluginActionExecutionData).Plugin}, no more preparation.");
	return null;
	}
	else if (actionDefinitionData.Execution.ExecutionType == ActionExecutionType.Composite)

If I understood correctly v3 remains to be ok to use for an extended time, e.g. until GHES instances have v4 support