Updated go-gh package #61
Conversation
| @@ -5,31 +5,34 @@ go 1.18 | |||
| require ( | |||
| github.com/AlecAivazis/survey/v2 v2.3.5 | |||
| github.com/TwiN/go-color v1.1.0 | |||
| github.com/cli/go-gh v0.1.0 | |||
| github.com/cli/go-gh v1.2.1 | |||
There was a problem hiding this comment.
This is a major version change. Do our e2e tests cover scenarios to ensure that nothing is broken due to this?
|
Is this PR still being considered? The extension is currently unusable on the latest gh CLI. |
|
It says: But it appears that there is an approving review. Is there a reason this PR isn't being merged automatically? Oh "reviewers with write access". |
|
Pweease can we get this merged |
|
Hi @VivaLaPanda @myk002 @realberliner75 @msfjarvis @KrazyKrazy8 I have created a fork for the project and released a new version |
|
👋 Hi, sorry for the delay. My team is taking a look at this now. |
|
Looks like #74 already did this. Can you release a new version of the extension? It remains unusable on the last gh cli. |
What are you trying to accomplish?
Updated go-gh package due to addition of support for secure token storage in go-gh which might break the old code.
Fixes this - #59
What approach did you choose and why?
Anything you want to highlight for special attention from reviewers?