Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set actions client timeout to 5 minutes, add logging to client #3103

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

nikola-jokic
Copy link
Member

Fixes potential problems of not timing out the request on actions client.

Likely fixes #3100

@nikola-jokic nikola-jokic added the gha-runner-scale-set Related to the gha-runner-scale-set mode label Nov 23, 2023
Copy link
Collaborator

@Link- Link- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's ship it

@nikola-jokic nikola-jokic merged commit b202be7 into master Nov 24, 2023
15 checks passed
@nikola-jokic nikola-jokic deleted the nikola-jokic/actions-client-timeout branch November 24, 2023 16:04
@audunsolemdal
Copy link

Any chance for a new release including this patch soon? This is causing a headache for my org.

@nikola-jokic
Copy link
Member Author

nikola-jokic commented Nov 28, 2023

Hey @audunsolemdal,

This PR is a mitigation to help recover the client in case of network issues. The best course of action is to actually troubleshoot what is filtering packets. We can do a patch release after we confirm this PR mitigates the issue. Would you be willing to test and confirm that the issue is mitigated with the canary image?

To do so, you should:

  1. In the gha-runner-scale-set-controller values.yaml file, update the tag value to: canary-b202be7
  2. Update the field appVersion in the Chart.yaml file for gha-runner-scale-set to be: canary-b202be7
  3. Redeploy ARC using the updated helm chart and values.yaml files

@audunsolemdal
Copy link

This PR is a mitigation to help recover the client in case of network issues. The best course of action is to actually troubleshoot what is filtering packages. We can do a patch release after we confirm this PR mitigates the issue. Would you be willing to test and confirm that the issue is mitigated with the canary image?

Ok, I will update YAML specs now and report back. Thanks for the guidance.

@audunsolemdal
Copy link

This PR is a mitigation to help recover the client in case of network issues. The best course of action is to actually troubleshoot what is filtering packages. We can do a patch release after we confirm this PR mitigates the issue. Would you be willing to test and confirm that the issue is mitigated with the canary image?

Ok, I will update YAML specs now and report back. Thanks for the guidance.

I keep getting this error

AutoscalingRunnerSet    Autoscaling runner set version doesn't match the build version. Deleting the resource.    {"autoscalingrunnerse ││ t": {"name":"actions-runner-pwsh","namespace":"gha-app-runners"}, "targetVersion": "canary-b202be7", "actualVersion": "0.6.1"} 

even though I have updated the YAML specs in both places. Am I missing something?

@nikola-jokic
Copy link
Member Author

Are you using an OCI chart or a path to the chart?
The best way would be to clone the ARC, then modify the appVersion and use the path to the gha-runner-scale-set directly. Unfortunately, helm does not allow modifying appVersion if it is not semver helm/helm#3555

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha-runner-scale-set Related to the gha-runner-scale-set mode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Listener randomly turns non-responsive after some time
3 participants