Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update formidable version and adjust for compatibility #2767

Merged
merged 1 commit into from Apr 26, 2024

Conversation

slrv
Copy link
Contributor

@slrv slrv commented Apr 26, 2024

The "formidable" version is updated from 2.1.2 to 3.5.1.

Corresponding changes have been made in the "web.ts" file to ensure backward compatibility between "formidable" version 3 and 2. Adjustments are made to deal with the removal of the multiples option and mechanism in "formidable" v3.

All tests passed.

The "formidable" version is updated from 2.1.2 to 3.5.1 in package.json and package-lock.json. Corresponding changes have been made in the "web.ts" file to ensure backward compatibility between "formidable" version 3 and 2. Adjustments are made to deal with the removal of the `multiples` option and mechanism in "formidable" v3.
Copy link
Member

@evantahler evantahler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work with the backwards compatibility! The tests pass, so 👍

@evantahler evantahler merged commit 2f2b7ce into actionhero:main Apr 26, 2024
8 checks passed
@evantahler
Copy link
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants