Allow custom content-type header for sending files

[321hendrik]

Makes it possible to configure the content-type header before sending a file.

Use case:

• There is a file named test.png_preview
• Mimetype can not be inferred from file extension
• You want to specify the type yourself in the download action

[evantahler]

I understand your use-case, and I agree we should allow for a way to make this change. I think that I would prefer the server/action be in control of if we want to set a custom mimeType rather than relying on a user request's header (which could be anything), e.g.:

await data.connection.sendFile("logo/actionhero.png", {mimeType: "application-foo"});

If the sendFile method were changed instead, then application could verify that the mimetype that is was about to set was valid/reasonable vs just passing back whatever the user requested... which could get folks into trouble (e.g. application/x-msdownload)

[evantahler]

Ping! Are you still interested in working on this?

[321hendrik]

I tried to implement your suggestion. Is this how you imagined?
The mimetype validation is just an example, could be more strict.

As for my use-case, I do not want to set a mimetype from user input. I want to be able to set a specific mimetype in my action. Maybe the test is misleading here.

[evantahler]

Your implementation is 👍, but I think modifying the sendFile action ins misleading here, because we don't really want this behavior in the action. You could make a new mock action in the test (e.g.) with that tests the behavior

[evantahler]

Hello! Checking in again to see if you need help