Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modern websocket client & Server #1949

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
277 changes: 0 additions & 277 deletions client/ActionheroWebsocketClient.js

This file was deleted.

14 changes: 14 additions & 0 deletions clients.tsconfig.json
@@ -0,0 +1,14 @@
{
"compilerOptions": {
"outDir": "./public/clients",
"allowJs": true,
"target": "es2020",
"lib": ["es2020", "DOM"],
"module": "ES2020",
"sourceMap": true,
"allowSyntheticDefaultImports": true,
"declaration": true,
"types": []
},
"include": ["./src/clients/**/*"]
}
Comment on lines +1 to +14
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The client lib has a different ES target than the rest of the project

21 changes: 20 additions & 1 deletion package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

7 changes: 5 additions & 2 deletions package.json
Expand Up @@ -49,7 +49,7 @@
"qs": "^6.10.1",
"uuid": "^8.3.2",
"winston": "^3.3.3",
"ws": "^8.2.0",
"ws": "^8.2.1",
"yargs": "^17.1.1"
},
"devDependencies": {
Expand All @@ -59,6 +59,7 @@
"@types/primus": "^7.3.5",
"@types/puppeteer": "^5.4.4",
"@types/uuid": "^8.3.1",
"@types/ws": "^7.4.7",
"ioredis-mock": "^5.6.0",
"jest": "^27.0.6",
"prettier": "^2.3.2",
Expand Down Expand Up @@ -86,12 +87,14 @@
"scripts": {
"postinstall": "echo 'To generate a new actionhero project, run \"npx actionhero generate\"'",
"test": "jest",
"prepare": "npm run build && npm run docs",
"prepare": "npm run build && npm run build-clients && npm run docs",
"pretest": "npm run lint && npm run build",
"dev": "ts-node-dev --transpile-only --no-deps ./src/server",
"debug": "tsc && ts-node-dev --transpile-only --no-deps --inspect -- ./src/server ",
"start": "node ./dist/server.js",
"build": "rm -rf dist && ./node_modules/.bin/tsc --sourceMap false --declaration",
"build-clients": "rm -rf public/clients && ./node_modules/.bin/tsc --declaration --project clients.tsconfig.json",
"watch": "rm -rf dist && ./node_modules/.bin/tsc --sourceMap false --declaration --watch",
"docs": "typedoc --out docs --theme default src/index.ts",
"lint": "prettier --check src __tests__",
"pretty": "prettier --write src __tests__"
Expand Down