Modern websocket client & Server #1949
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evantahler
force-pushed
the
modern-ws-client
branch
from
d43431f
to
014a36f
Compare
evantahler
commented
Sep 12, 2021
Comment on lines
+61
to
+67
| const url = window.location.origin | ||
| .replace("https://", "wss://") | ||
| .replace("http://", "ws://"); | ||
|
|
||
| const client = new ActionheroWebsocketClient(url, { | ||
| cookieKey: "sessionID", | ||
| }); |
There was a problem hiding this comment.
ActionheroWebsocketClient would now require some options, eg the URL and cookie settings
Comment on lines
+73
to
+83
| client.onDisconnect = () => { | ||
| console.log("Disconnected!"); | ||
| }; | ||
|
|
||
| client.onSay = (message) => { | ||
| appendMessage(message); | ||
| }; | ||
|
|
||
| client.onWelcome = (message) => { | ||
| appendMessage(message); | ||
| }; |
There was a problem hiding this comment.
Looks like we still don't have EventEmitter or something like it in the browser that can handle custom payloads
Comment on lines
+87
to
+91
| try { | ||
| await client.action("createChatRoom", { name: "defaultRoom" }); | ||
| } catch (error) { | ||
| if (error.message !== "room exists") throw error; | ||
| } |
There was a problem hiding this comment.
All Async/Await now, even in the browser!
Comment on lines
+58
to
+59
| <script type="module"> | ||
| import { ActionheroWebsocketClient } from "../clients/websocket.js"; |
There was a problem hiding this comment.
We can don dynamic imports in the browser with JS modules
Comment on lines
+1
to
+14
| { | ||
| "compilerOptions": { | ||
| "outDir": "./public/clients", | ||
| "allowJs": true, | ||
| "target": "es2020", | ||
| "lib": ["es2020", "DOM"], | ||
| "module": "ES2020", | ||
| "sourceMap": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "declaration": true, | ||
| "types": [] | ||
| }, | ||
| "include": ["./src/clients/**/*"] | ||
| } |
There was a problem hiding this comment.
The client lib has a different ES target than the rest of the project
| data: DataType; | ||
| }; | ||
|
|
||
| export class ActionheroWebsocketClient { |
There was a problem hiding this comment.
A new, strongly typed TS class for ActionheroWebsocketClient
|
|
||
| export const DEFAULT = { | ||
| servers: { | ||
| websocket: (config) => { | ||
| websocket: () => { | ||
| return { | ||
| enabled: true, |
There was a problem hiding this comment.
Almsot no server options now!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1946
The goals of this exploration are to:
primusand just usewson the server and the browser's built-inWebSocketlibrary. It's 2021!ActionHeroWebSocketClientthat can be included in React and Angular projectsActionHeroWebSocketClient.jsthat can still be used by "static"/"simple" HTML projects (eg: the samplechat.jsthat ships with Actionhero