Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re: Root Users #11

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

cerulean-skies
Copy link

Heya mcfarhat! I figured I would just give it a go :) Hope you're having a good one today. Hit me back up whenever. Weekend n all that, no rush at all.

Implemented changes in onResume(), where we will now check for, and restrict Root Users from accessing application
Class used to test for Root Access
@cerulean-skies cerulean-skies changed the title Not really sure what to put here ^^ Super hoping this isn't public... Re: RootChecker Re: Root Users Aug 17, 2018
@mcfarhat
Copy link
Collaborator

Hey man,
Thanks for the work. I think its best if this is associated with the oncreate event, not the onresume? Give it a try there and see how the app responds.
Also you dont need to comment on every line of code, just wherever there could be lack of clarity, or to describe functions etc... feel free to check my comment style as well.
Let me know once you've double checked this.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants