Add the option to ignore SSL verfication errors #9

oiosaway · 2015-06-23T20:46:59Z

Fixes #7

acomminos · 2015-08-03T17:32:48Z

src/main/java/com/morlunk/jumble/net/JumbleSSLSocketFactory.java

@@ -89,7 +92,11 @@ public SSLSocket createSocket(InetAddress host, int port) throws IOException {
     * @return The remote server's certificate chain, or null if a connection has not reached handshake yet.
     */
    public X509Certificate[] getServerChain() {
-        return mTrustWrapper.getServerChain();
+        if(mTrustWrapper instanceof JumbleTrustManagerWrapper) {


Perhaps it may be a good idea to make an interface for a trust manager that can provide the remote's certificate chain. instanceof is generally discouraged.

LOL, this patch is hilarious

Add the option to ignore SSL verfication errors

d2d1a0b

acomminos reviewed Aug 3, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add the option to ignore SSL verfication errors #9

Add the option to ignore SSL verfication errors #9

oiosaway commented Jun 23, 2015

acomminos Aug 3, 2015

CarlLee Oct 16, 2015

Add the option to ignore SSL verfication errors #9

Are you sure you want to change the base?

Add the option to ignore SSL verfication errors #9

Conversation

oiosaway commented Jun 23, 2015

acomminos Aug 3, 2015

Choose a reason for hiding this comment

CarlLee Oct 16, 2015

Choose a reason for hiding this comment