Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom comment option #5054

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

mib1185
Copy link

@mib1185 mib1185 commented Mar 14, 2024

This adds an option, where the user can add some custom comments to each certificate configuration. This would be helpful to add additional information to a certificate like it's usage or any other comments.

example:
real domain is redacted

# acme.sh --issue -d mib1185-test.mydomain.com --comment "this is just a test comment" -w /var/www
[...]

# acme.sh --info -d mib1185-test.mydomain.com
[Thu Mar 14 15:47:24 CET 2024] The domain 'mib1185-test.mydomain.com' seems to have a ECC cert already, lets use ecc cert.
DOMAIN_CONF=/ACME/configfiles/mib1185-test.mydomain.com_ecc/mib1185-test.mydomain.com.conf
Le_Domain=mib1185-test.mydomain.com
Le_Alt=no
Le_Webroot=/var/www
Le_PreHook=
Le_PostHook=
Le_RenewHook=
Le_Comment=this is just a test comment
Le_API=https://acme-v02.api.letsencrypt.org/directory
[...]

@mib1185
Copy link
Author

mib1185 commented Mar 18, 2024

@Neilpang unfortunately i'm not allowed to restart the failed CI job, but it seems not to be related to the change itself.

@mib1185 mib1185 closed this Mar 20, 2024
@mib1185 mib1185 reopened this Mar 20, 2024
@mib1185
Copy link
Author

mib1185 commented Apr 8, 2024

@Neilpang do you mind to restart the CI?

@mib1185
Copy link
Author

mib1185 commented Apr 30, 2024

Hi @Neilpang i don't understand the failing test and if it is related to my change. do you have any hints on this and how to resolve it?

@Neilpang
Copy link
Member

sorry, but I don't think this is a good idea to support comments after thinking more about it. It's not necessary.

@mib1185
Copy link
Author

mib1185 commented Apr 30, 2024

i agree that it is technically not necessary, but would help a lot to handle and manage multiple certificates per any kind of automation tools (eq. ansible)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants