Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed handling of key and secret #5049

Merged
merged 4 commits into from Apr 29, 2024
Merged

Conversation

hknet
Copy link
Contributor

@hknet hknet commented Mar 11, 2024

fixed handling of key and secret values read from acme's account.conf

Copy link

Welcome
First thing: don't send PR to the master branch, please send to the dev branch instead.
Please make sure you've read our DNS API Dev Guide and DNS-API-Test.
Then reply on this message, otherwise, your code will not be reviewed or merged.
We look forward to reviewing your Pull request shortly ✨
注意: 必须通过了 DNS-API-Test 才会被 review. 无论是修改, 还是新加的 dns api, 都必须确保通过这个测试.

@Neilpang
Copy link
Member

what is this for? more explaination ?

@hknet
Copy link
Contributor Author

hknet commented Mar 18, 2024

previously already stored values in account.conf were not handled in a way to work with those values, this is would be fixed using this PR.

@hknet
Copy link
Contributor Author

hknet commented Apr 29, 2024

could I ask to merge this fix as the current master release does not handle account data already stored correctly.

@Neilpang Neilpang merged commit e7cfde1 into acmesh-official:dev Apr 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants