Add deploy/zyxel_gs1900.sh #5043
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm now using this version locally for my switches. Please let me know if there is anything you'd like me to do to improve the PR. No rush. :) |
|
A bug has occurred on one of my servers with a different version of sed. Working on a fix now. |
|
Most recent commit should have resolved the issue I found. |
Neilpang
reviewed
Mar 17, 2024
coderjoe
commented
Mar 27, 2024
coderjoe
commented
Mar 27, 2024
coderjoe
force-pushed
the
feature/deploy-to-zyxel-gs1900-switches
branch
from
90a91a2
to
2bedbad
Compare
|
I've updated for the shellcheck and shfmt linting in the previous run, have removed the defunct curl errors (now that curl is not a requirement) and have squashed the commit to clean up history a bit. |
|
I've verified that the updated commits continue to work in all of my deployed environments. I don't think I would have figured it out without your suggestion. :) |
Neilpang
reviewed
Apr 7, 2024
Add support for deploying to the Zyxel GS1900 line of switches as long as those switches are running at least firmware V2.80. Tested on a Zyxel GS1900-8 and GS1900-24E Resolves acmesh-official#5042
coderjoe
force-pushed
the
feature/deploy-to-zyxel-gs1900-switches
branch
from
8646c3b
to
721e57c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for deploying to the Zyxel GS1900 line of switches as long as those switches are running at least firmware V2.80.
Tested on a Zyxel GS1900-8 and GS1900-24E
Resolves #5042